[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/23] bsd-user: add more strace formating
From: |
Stacey Son |
Subject: |
Re: [Qemu-devel] [PATCH 22/23] bsd-user: add more strace formating |
Date: |
Mon, 24 Jun 2013 15:55:35 -0500 |
On Jun 24, 2013, at 12:41 PM, Peter Maydell wrote:
> On 24 June 2013 03:03, Stacey Son <address@hidden> wrote:
>> This change add more strace formating for popular system calls. It also
>> separates out *BSD and architecture dependent code. In addition, it
>> changes TARGET_OS in configure (and in the associated makefiles) to
>> what it should really be: HOST_OS.
>
> You introduced TARGET_OS in the first place. Please don't put
> code in in one patch and then change it in a later one; rearrange
> your patchset to avoid this.
>
> This patch is also doing too many things at once.
>
>> +if [ "$HOST_ABI_DIR" != "" ]; then
>> + echo "HOST_ABI_DIR=$HOST_ABI_DIR" >> $config_target_mak
>> +fi
>
> Host specific definitions in the target config? Doesn't look right.
You're right. I originally used TARGET_OS but later decided that it was not
the target but really the host os that was being defined. Then after rebasing
I noticed that there was a change defining TARGET_ABI_DIR so I changed HOST_OS
to HOST_ABI_DIR to be consistent with that change. I really need to may this
change back when TARGET_OS is first introduced.
-stacey.
- Re: [Qemu-devel] [PATCH 10/23] bsd-user: add shims for memory management related syscalls, (continued)
- [Qemu-devel] [PATCH 09/23] bsd-user: refresh FreeBSD's system call numbers, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 12/23] bsd-user: add shims for time related system calls., Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 03/23] bsd-user: additional seperation of OS and architecture dependent code, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 04/23] bsd-user: add bsd signal emulation, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 22/23] bsd-user: add more strace formating, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 20/23] bsd-user: add shims for extended attributes system calls, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 18/23] bsd-user: add shim for the ioctl system call, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 16/23] bsd-user: add shims for stat and file handle related syscalls, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 15/23] bsd-user: add shims for socket related system calls, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 14/23] bsd-user: add shims for process related system calls, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 21/23] bsd-user: add miscellaneous system call shims, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 17/23] bsd-user: add shims for thread related system calls, Stacey Son, 2013/06/24
- [Qemu-devel] [PATCH 19/23] bsd-user: add shims for sysarch() and sysctl() system calls, Stacey Son, 2013/06/24