[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit condi
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll() |
Date: |
Thu, 27 Jun 2013 15:14:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto:
> Check exit conditions before entering blocking aio_poll(). This is
> mainly for consistency since it's unlikely that we are stopping in the
> first event loop iteration.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
> index 0356665..0509d3f 100644
> --- a/hw/block/dataplane/virtio-blk.c
> +++ b/hw/block/dataplane/virtio-blk.c
> @@ -379,9 +379,9 @@ static void *data_plane_thread(void *opaque)
> {
> VirtIOBlockDataPlane *s = opaque;
>
> - do {
> + while (!s->stopping || s->num_reqs > 0) {
> aio_poll(s->ctx, true);
> - } while (!s->stopping || s->num_reqs > 0);
> + }
> return NULL;
> }
>
>
ACK
Paolo
- Re: [Qemu-devel] [PATCH v4 01/17] block: stop relying on io_flush() in bdrv_drain_all(), (continued)
- [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics, Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 06/17] block/curl: drop curl_aio_flush(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 07/17] block/gluster: drop qemu_gluster_aio_flush_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 08/17] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 09/17] block/linux-aio: drop qemu_laio_completion_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 10/17] block/nbd: drop nbd_have_request(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 11/17] block/rbd: drop qemu_rbd_aio_flush_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll(), Stefan Hajnoczi, 2013/06/14
- Re: [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll(),
Paolo Bonzini <=
- [Qemu-devel] [PATCH v4 12/17] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 03/17] tests: adjust test-aio to new aio_poll() semantics, Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 13/17] block/ssh: drop return_true(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 15/17] thread-pool: drop thread_pool_active(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 16/17] tests: drop event_active_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 17/17] aio: drop io_flush argument, Stefan Hajnoczi, 2013/06/14