Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

[Petar Jovanovic]

________________________________________
From: Richard Henderson address@hidden on behalf of Richard Henderson 
address@hidden
Sent: Friday, June 28, 2013 7:40 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; address@hidden; address@hidden
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

On 06/27/2013 02:48 PM, Petar Jovanovic wrote:
>> This doesn't look right either, as it doesn't properly check for overflow of
>> negative values.
>
> What overflow of negative values?
> Can you please list the values for which the result would not be correct?

> Hmm, I suppose since we're always rounding to +INF, we can't
> overflow in the negative direction.  The patch could use some
> commentary along those lines...
> r~

Ok, I will add comments in the code and resubmit the patch.

Petar