[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.9 16/17] tests: query-cpu-model-test.py test c
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH for-2.9 16/17] tests: query-cpu-model-test.py test code |
Date: |
Fri, 2 Dec 2016 19:18:15 -0200 |
This python script will run query-cpu-model-expansion and related
commands, and sanity-check the results. It seems to work with
qemu-system-s390x, already, but I don't have a host where I can
make sure the test case work for all CPU models.
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/query-cpu-model-test.py | 421 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 421 insertions(+)
create mode 100755 tests/query-cpu-model-test.py
diff --git a/tests/query-cpu-model-test.py b/tests/query-cpu-model-test.py
new file mode 100755
index 0000000..0d99242
--- /dev/null
+++ b/tests/query-cpu-model-test.py
@@ -0,0 +1,421 @@
+#!/usr/bin/env python
+#
+# query-cpu-model-* sanity checks
+#
+# Copyright (c) 2016 Red Hat Inc
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, see <http://www.gnu.org/licenses/>.
+#
+
+import sys, os
+sys.path.append(os.path.join(os.path.dirname(__file__), '..', 'scripts'))
+from qtest import QEMUQtestMachine
+import unittest
+import logging
+
+UNSAFE_FEATURES = {
+ 'x86_64': ['pmu', 'host-cache-info'],
+ 'i386': ['pmu', 'host-cache-info'],
+}
+
+# Validation of the expanded CPU models will be based on the QOM
+# properties of CPU objects.
+# QOM properties that don't affect guest ABI can be safely ignored
+# when validating the results.
+IGNORE_QOM_PROPS = {
+ # the 'type' property just identifies the QOM class being used
+ # to build the CPU, and shouldn't affect the guest ABI
+ 'x86_64': ['type'],
+ 'i386': ['type'],
+ # 'static', 'migration-safe', and 'description' are just
+ # information for the user, and don't affect guest ABI
+ 's390x': ['type', 'static', 'migration-safe', 'description'],
+}
+
+def toQemuOpts(*args):
+ """Convert arguments to a QemuOpts string, with appropriate escaping
+
+ Each argument can be a single string, or a dictionary.
+ """
+ logging.debug('toQemuOpts(%r)', args)
+ r = []
+ for a in args:
+ if type(a) is dict:
+ for k,v in a.items():
+ if type(v) is bool:
+ if v:
+ v = 'on'
+ else:
+ v = 'off'
+ v = str(v)
+ a = '%s=%s' % (k, v)
+ r.append(a)
+ else:
+ a = str(a)
+ r.append(a)
+ return ','.join([o.replace(',', ',,') for o in r])
+
+def cpuPath(vm, cpu_index):
+ """Return qom_path for a given CPU, using query-cpus"""
+ cpus = vm.command('query-cpus')
+ return cpus[cpu_index]['qom_path']
+
+def allProps(vm, path):
+ """Return a dictionary containing all properties for a QOM object"""
+ props = vm.command('qom-list', path=path)
+ r = {}
+ for prop in props:
+ pname = prop['name']
+ v = vm.command('qom-get', path=path, property=pname)
+ r[pname] = v
+ return r
+
+def allCpuProps(vm, cpu_index):
+ """Return all properties for a given CPU"""
+ return allProps(vm, cpuPath(vm, cpu_index))
+
+
+class CPUModelTest(unittest.TestCase):
+ longMessage = True
+ maxDiff = None
+
+ def runAndGetProps(self, model):
+ # Helper to run QEMU using a CpuModelInfo struct and get
+ # all CPU properties
+ cpu_opt = toQemuOpts(model['name'], model.get('props', {}))
+ logging.debug('cpu option: %s', cpu_opt)
+
+ vm = QEMUQtestMachine(args=['-machine', 'accel=%s' % (self.accel),
'-S',
+ '-cpu', cpu_opt], name='qom-fetch',
+ logging=False)
+ try:
+ vm.launch()
+ props = allCpuProps(vm, 0)
+ finally:
+ vm.shutdown()
+
+ # remove the properties we can ignore
+ for p in IGNORE_QOM_PROPS.get(self.target['arch'], []):
+ del props[p]
+
+ return props
+
+ def tryGetProps(self, model, msg):
+ """Try to get QOM props for model, if runnable"""
+ if model.get('runnable') != False:
+ logging.info("%s: maybe runnable, fetching QOM properties", msg)
+ try:
+ model['qom-props'] = self.runAndGetProps(model['model'])
+ except:
+ if model.get('runnable'):
+ # explicitly marked as runnable, raise exception
+ raise
+ logging.info("%s: failed to run VM, ignoring", msg)
+
+ def checkOneExpansion(self, model, type, msg):
+ """Perform one query-cpu-model-expansion operation, validate results
+
+ @model is a CpuModelExpansionInfo struct, with some extra keys:
+ * model['runnable'] will be set to True if the CPU model is
+ runnable on this host
+ * model['qom-props'] will be set to the full list of properties for the
+ CPU, if the model is runnable
+
+ Returns a new CpuModelExpansion struct like @model, with
+ the expanded CPU model data.
+ """
+ logging.info("%s: testing type=%s", msg, type)
+ logging.debug("%s: model: %r", msg, model)
+
+ expanded = self.vm.command('query-cpu-model-expansion',
+ type=type, model=model['model'])
+
+ logging.debug("%s: expanded: %r", msg, expanded)
+
+ # static expansions are always migration-safe
+ if expanded['static']:
+ self.assertTrue(expanded['migration-safe'])
+
+ # static expansion mode should always result in static/expansion-safe
+ # expansions
+ if type == 'static':
+ self.assertTrue(expanded['static'], msg)
+ self.assertTrue(expanded['migration-safe'], msg)
+ expanded_model = self.cpu_models[expanded['model']['name']]
+ self.assertTrue(expanded_model['static'])
+ self.assertTrue(expanded_model['migration-safe'])
+ else:
+ # full expansion should not clear static and migration-safe info
+ # from # original model:
+ if model['static']:
+ self.assertTrue(expanded['static'], msg)
+ if model['migration-safe']:
+ self.assertTrue(expanded['migration-safe'], msg)
+
+ # migration-safe expansion should never enable migration-unsafe
+ # features:
+ if expanded['migration-safe']:
+ for f in UNSAFE_FEATURES.get(self.target['arch'], []):
+ self.assertFalse(expanded['model']['props'].get(f))
+
+ # Some expansions are known to be precise, and shouldn't lose any
+ # features:
+ # * full expansion
+ # * static expansion of a migration-safe model
+ precise_expansion = (type == 'full' or model['migration-safe'])
+
+ # full expansion should keep all existing explicit properties
+ # in the output:
+ if type == 'full':
+ originalprops = model['model'].get('props', {})
+ fullprops = expanded['model'].get('props', {})
+ for p in originalprops.keys():
+ self.assertEquals(originalprops[p], fullprops.get(p),
+ '%s: property %s lost in full expansion'
+ % (msg, p))
+
+ expanded['runnable'] = model.get('runnable')
+ self.tryGetProps(expanded, msg)
+ if precise_expansion:
+ self.assertEquals(model.get('qom-props'),
+ expanded.get('qom-props'),
+ msg)
+
+ logging.debug("%s: result: %r", msg, expanded)
+ return expanded
+
+ def checkExpansions(self, model, msg):
+ """Performe multiple expansion operations on model, validate results
+
+ @model is a CpuModelExpansionInfo struct, with some extra keys:
+ * model['runnable'] should be set to True if the CPU model is
+ runnable on this host
+ * model['qom-props'] will be set to the full list of properties for
+ the CPU, if the model is runnable
+ """
+ self.tryGetProps(model, msg)
+
+ exp_s = self.checkOneExpansion(model, 'static',
+ '%s.static' % (msg))
+ exp_f = self.checkOneExpansion(model, 'full',
+ '%s.full' % (msg))
+ exp_ss = self.checkOneExpansion(exp_s, 'static',
+ '%s.static.static' % (msg))
+ exp_sf = self.checkOneExpansion(exp_s, 'full',
+ '%s.static.full' % (msg))
+ exp_ff = self.checkOneExpansion(exp_f, 'full',
+ '%s.full.full' % (msg))
+
+ # static expansion twice should result in the same data:
+ self.assertEquals(exp_s, exp_ss)
+ # full expansion twice should also result in the same data:
+ self.assertEquals(exp_f, exp_ff)
+
+ # migration-safe CPU models have an extra feature:
+ # their static expansion should be equivalent to the full
+ # expansion (as static expansion is also precise)
+ if model.get('migration-safe'):
+ self.assertEquals(exp_sf, exp_f)
+
+ def tryToMakeRunnable(self, model):
+ """Try to create a runnable version of the CPU model, by disabling
+ unavailable features
+ """
+ devprops = self.vm.command('device-list-properties',
+ typename=model['typename'])
+ proptypes = dict((p['name'], p['type']) for p in devprops)
+
+ props = {}
+ for f in model['unavailable-features']:
+ # try to disable only boolean properties:
+ if proptypes.get(f) == 'bool':
+ props[f] = False
+
+ if not props:
+ # no property found to be disabled, there's nothing we can do
+ return None
+
+ runnable_model = {
+ 'model': {
+ 'name': model['name'],
+ 'props': props,
+ },
+ 'static': model.get('static', False),
+ 'migration-safe': model.get('migration-safe', False),
+ }
+ return runnable_model
+
+ def commandAvailable(self, command):
+ commands = self.vm.command('query-commands')
+ names = set([c['name'] for c in commands])
+ return command in names
+
+ def checkRunnability(self, model):
+ """Check runnability of a given CPU model
+
+ Use unavailable-features field, if available. Otherwise,
+ used query-cpu-model-comparison with "host" CPU model.
+
+ Fills the 'unavailable-features' field based on the results.
+ """
+ if not self.commandAvailable('query-cpu-model-comparison'):
+ logging.debug("query-cpu-model-comparison is not availabble")
+ return
+
+ comparison = self.vm.qmp('query-cpu-model-comparison',
+ modela=dict(name=model['name']),
+ modelb=dict(name='host'))
+ logging.info("comparison result: %r", comparison)
+ if not comparison.has_key('return'):
+ logging.debug("query-cpu-model-comparison failed")
+ return
+
+ comparison = comparison['return']
+
+ # if unavailable-features was already set, it must match the
+ # results of query-cpu-model-comparison
+ unavailable_features = model.get('unavailable-features')
+ if unavailable_features is not None:
+ if len(unavailable_features) == 0:
+ self.assertTrue(comparison['result'] in ['identical',
'subset'])
+ else:
+ self.assertIn(comparison['result'],
+ ['superset', 'incompatible'])
+ self.assertEquals(comparison['responsible-properties'],
+ unavailable_features)
+ model['unavailable-features'] = comparison['responsible-properties']
+
+ def checkOneCPUModel(self, m):
+ """Run multiple query-cpu-model-expansion checks
+
+ * Test simple CPU model name
+ * Test CPU model with unsafe features enabled
+ * Test CPU model with unavailable features disabled,
+ if unavailable-features is set
+ """
+ msg = '%s.%s' % (self.accel, m['name'])
+ logging.info("%s: checkOneCPUModel", msg)
+
+
+ # some validations on query-cpu-definitions output:
+ if m.get('static'):
+ self.assertTrue(m['migration-safe'])
+
+ self.checkRunnability(m)
+
+ # simulate return value of query-cpu-expansion for the model:
+ model = {
+ 'model': {
+ 'name': m['name'],
+ },
+ 'static': m.get('static', False),
+ 'migration-safe': m.get('migration-safe', False),
+ }
+ if m.has_key('unavailable-features'):
+ model['runnable'] = len(m['unavailable-features']) == 0
+ self.checkExpansions(model, msg)
+
+ # explicit test to check we do the right thing when
+ # unsafe features are enabled explicitly:
+ for f in UNSAFE_FEATURES.get(self.target['arch'], []):
+ # enabled:
+ unsafe_model = {
+ 'model': {
+ 'name': m['name'],
+ 'props': { f: True },
+ },
+ 'migration-safe': False,
+ 'static': False,
+ 'runnable': model.get('runnable'),
+ }
+ self.checkExpansions(unsafe_model, msg + ".unsafe." + f)
+
+ # Check if CPU model can be made migration-safe
+ # if we disable all known migration-unsafe features:
+ if not m.get('migration-safe'):
+ # enabled:
+ safe_model = {
+ 'model': {
+ 'name': m['name'],
+ 'props': {}
+ },
+ 'migration-safe': True,
+ 'static': m.get('static', False),
+ 'runnable': model.get('runnable'),
+ }
+ for f in UNSAFE_FEATURES.get(self.target['arch'], []):
+ safe_model['model']['props'][f] = False
+ self.checkExpansions(safe_model, msg + ".safe")
+
+ # if not runnable, try to create a runnable version of the CPU model:
+ if m.get('unavailable-features'):
+ runnable_model = self.tryToMakeRunnable(m)
+ if runnable_model:
+ self.checkExpansions(runnable_model, msg + ".runnable")
+
+ @classmethod
+ def setUpClass(klass):
+ vm = QEMUQtestMachine(args=['-S'], logging=False)
+ try:
+ vm.launch()
+ klass.kvm = vm.command('query-kvm')
+ klass.target = vm.command('query-target')
+ finally:
+ vm.shutdown()
+
+ def setUp(self):
+ self.vm = None
+
+ def tearDown(self):
+ if self.vm:
+ self.vm.shutdown()
+
+ def checkAllCPUModels(self):
+ self.vm = QEMUQtestMachine(args=['-S', '-machine',
+ 'accel=%s' % (self.accel)],
+ logging=False)
+ self.vm.launch()
+ self.cpu_models = dict((m['name'], m) for m in
+ self.vm.command('query-cpu-definitions'))
+
+ if self.accel.split(':')[0] == 'kvm':
+ if not self.vm.command('query-kvm')['enabled']:
+ self.skipTest("Failed to enable KVM")
+
+ for m in self.cpu_models.values():
+ self.checkOneCPUModel(m)
+
+ def testTCGModels(self):
+ self.accel = 'tcg'
+ self.checkAllCPUModels()
+
+ def testKVMModels(self):
+ # use kvm:tcg so QEMU won't refuse to start if KVM is unavailable
+ self.accel = 'kvm:tcg'
+ # test KVM also, if present
+ if not self.kvm['present']:
+ self.skipTest("KVM is not present")
+
+ self.checkAllCPUModels()
+
+
+
+if __name__ == '__main__':
+ if os.getenv('QTEST_LOG_LEVEL'):
+ logging.basicConfig(level=int(os.getenv('QTEST_LOG_LEVEL')))
+ elif '--verbose' in sys.argv:
+ logging.basicConfig(level=logging.INFO)
+ else:
+ logging.basicConfig(level=logging.WARN)
+ unittest.main()
--
2.7.4
- Re: [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model, (continued)
[Qemu-devel] [PATCH for-2.9 14/17] qapi: add static/migration-safe info to query-cpu-model-expansion, Eduardo Habkost, 2016/12/02
[Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command, Eduardo Habkost, 2016/12/02
[Qemu-devel] [PATCH for-2.9 16/17] tests: query-cpu-model-test.py test code,
Eduardo Habkost <=
Re: [Qemu-devel] [libvirt] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion, no-reply, 2016/12/05
Re: [Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion, David Hildenbrand, 2016/12/05