[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support
From: |
Longpeng (Mike) |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support |
Date: |
Mon, 5 Dec 2016 19:11:37 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
Hi Daniel,
On 2016/12/5 17:18, Daniel P. Berrange wrote:
> On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote:
......
>> diff --git a/qapi/crypto.json b/qapi/crypto.json
>> index 5c9d7d4..d403ab9 100644
>> --- a/qapi/crypto.json
>> +++ b/qapi/crypto.json
>> @@ -75,7 +75,7 @@
>> { 'enum': 'QCryptoCipherAlgorithm',
>> 'prefix': 'QCRYPTO_CIPHER_ALG',
>> 'data': ['aes-128', 'aes-192', 'aes-256',
>> - 'des-rfb',
>> + 'des-rfb', 'des',
>
> Can we call this '3des' to make it clear that this is Triple-DES and not
> the single-DES (which des-rfb is)
>
As the comment in qapi/crypto.json said:
@des-rfb: RFB specific variant of single DES.
This patch just add the standard single-DES support, not the triple-DES, so I
think maybe "des" is suitable.
And we will add "3des" in the near-future.
>> 'cast5-128',
>> 'serpent-128', 'serpent-192', 'serpent-256',
>> 'twofish-128', 'twofish-192', 'twofish-256']}
>
> Regards,
> Daniel
--
Regards,
Longpeng(Mike)
- [Qemu-devel] [PATCH for-2.9 0/3] crypto: add standard des support, Longpeng(Mike), 2016/12/05
- [Qemu-devel] [PATCH for-2.9 2/3] cryptodev: switch to standard des, Longpeng(Mike), 2016/12/05
- [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Longpeng(Mike), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/05
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/06
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Gonglei (Arei), 2016/12/06
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support,
Longpeng (Mike) <=
- Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Daniel P. Berrange, 2016/12/05
Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support, Eric Blake, 2016/12/05
[Qemu-devel] [PATCH for-2.9 3/3] tests: crypto: add testcase for standard des(ecb), Longpeng(Mike), 2016/12/05