[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and sha
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options |
Date: |
Mon, 5 Dec 2016 10:22:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/05/2016 02:35 AM, zhanghailiang wrote:
> We use these two options to identify which disk is
> shared
>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
> v2:
> - add these two options for BlockdevOptionsReplication to support
> qmp blockdev-add command.
> - fix a memory leak found by Changlong
> ---
> +++ b/qapi/block-core.json
> @@ -2232,12 +2232,19 @@
> # node who owns the replication node chain. Must not be given in
> # primary mode.
> #
> +# @shared-disk-id: #optional The id of shared disk while in replication mode.
> +#
> +# @shared-disk: #optional To indicate whether or not a disk is shared by
> +# primary VM and secondary VM.
Both of these need a '(since 2.9)' designation since they've missed 2.8,
and could probably also use documentation on the default value assumed
when the parameter is omitted.
> +#
> # Since: 2.8
> ##
> { 'struct': 'BlockdevOptionsReplication',
> 'base': 'BlockdevOptionsGenericFormat',
> 'data': { 'mode': 'ReplicationMode',
> - '*top-id': 'str' } }
> + '*top-id': 'str',
> + '*shared-disk-id': 'str',
> + '*shared-disk': 'bool' } }
>
> ##
> # @NFSTransport
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v2 0/6] COLO block replication supports shared disk case, zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 5/6] replication: Implement block replication for shared disk case, zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 3/6] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint(), zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 6/6] nbd/replication: implement .bdrv_get_info() for nbd and replication driver, zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case, zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options, zhanghailiang, 2016/12/05
- [Qemu-devel] [PATCH RFC v2 4/6] replication: fix code logic with the new shared_disk option, zhanghailiang, 2016/12/05