qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/1] vfio iommu type1: set size to PAGE_SIZE while l


From: Kirti Wankhede
Subject: [Qemu-devel] [PATCH 1/1] vfio iommu type1: set size to PAGE_SIZE while looking for iova in dma list
Date: Tue, 6 Dec 2016 02:38:01 +0530

In the functions of pin_pages/unpin_pages from mdev vendor driver,
vfio_find_dma() should be called with size as PAGE_SIZE instead of 0.
vfio_find_dma() searches for the range in dma_list.

In vfio_dma_do_unmap(), vfio_find_dma() when used to look for start
address of unmap->iova, size should be 1, not 0. Otherwise vfio_find_dma()
returns NULL.

Signed-off-by: Kirti Wankhede <address@hidden>
Signed-off-by: Neo Jia <address@hidden>
Change-Id: Iee6fd45441c342b5e8626087046b2e0075d19a08
---
 drivers/vfio/vfio_iommu_type1.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index a28fbddb505c..023fba7b8d5a 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -581,7 +581,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
                struct vfio_pfn *vpfn;
 
                iova = user_pfn[i] << PAGE_SHIFT;
-               dma = vfio_find_dma(iommu, iova, 0);
+               dma = vfio_find_dma(iommu, iova, PAGE_SIZE);
                if (!dma) {
                        ret = -EINVAL;
                        goto pin_unwind;
@@ -622,7 +622,7 @@ pin_unwind:
                dma_addr_t iova;
 
                iova = user_pfn[j] << PAGE_SHIFT;
-               dma = vfio_find_dma(iommu, iova, 0);
+               dma = vfio_find_dma(iommu, iova, PAGE_SIZE);
                vfio_unpin_page_external(dma, iova, do_accounting);
                phys_pfn[j] = 0;
        }
@@ -659,7 +659,7 @@ static int vfio_iommu_type1_unpin_pages(void *iommu_data,
                dma_addr_t iova;
 
                iova = user_pfn[i] << PAGE_SHIFT;
-               dma = vfio_find_dma(iommu, iova, 0);
+               dma = vfio_find_dma(iommu, iova, PAGE_SIZE);
                if (!dma)
                        goto unpin_exit;
                vfio_unpin_page_external(dma, iova, do_accounting);
@@ -826,7 +826,7 @@ again:
         * mappings within the range.
         */
        if (iommu->v2) {
-               dma = vfio_find_dma(iommu, unmap->iova, 0);
+               dma = vfio_find_dma(iommu, unmap->iova, 1);
                if (dma && dma->iova != unmap->iova) {
                        ret = -EINVAL;
                        goto unlock;
-- 
2.7.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]