[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec.c: simplify the breakpoint invalidation lo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] exec.c: simplify the breakpoint invalidation logic |
Date: |
Wed, 7 Dec 2016 06:32:10 -0500 (EST) |
> I think this is the wrong direction. We only need to invalidate
> the TBs for the specific location the breakpoint is at.
> Even if we for the moment want to apply a big hammer of doing
> a full tb flush on breakpoint to fix this issue for this release,
> we shouldn't drop the indirection through breakpoint_invalidate(),
> because then we can't go back to invalidating just the parts we need
> easily later.
I agree with Peter, but still this patch should be fine for
2.8 and we can revert it when MTTCG locking is merged.
Paolo