qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/6] ARM BE8/BE32 big-endian system-mode fixe


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v2 0/6] ARM BE8/BE32 big-endian system-mode fixes (semihosting, gdbstub)
Date: Wed, 7 Dec 2016 07:28:12 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/6] ARM BE8/BE32 big-endian system-mode fixes 
(semihosting, gdbstub)
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7c9492e ARM BE32 watchpoint fix.
0ea452a Fix Thumb-1 BE32 execution and disassembly.
c0a6f13 ARM big-endian system-mode gdbstub support.
e4aed6b ARM big-endian system-mode semihosting support.
bacdd0a Infer endianness from SCTLR reset value.
a054bd8 Add cfgend parameter for ARM CPU selection.

=== OUTPUT BEGIN ===
Checking PATCH 1/6: Add cfgend parameter for ARM CPU selection....
Checking PATCH 2/6: Infer endianness from SCTLR reset value....
Checking PATCH 3/6: ARM big-endian system-mode semihosting support....
Checking PATCH 4/6: ARM big-endian system-mode gdbstub support....
Checking PATCH 5/6: Fix Thumb-1 BE32 execution and disassembly....
Checking PATCH 6/6: ARM BE32 watchpoint fix....
ERROR: space prohibited between function name and open parenthesis '('
#35: FILE: include/qom/cpu.h:198:
+    vaddr (*adjust_watchpoint_address)(CPUState *cpu, vaddr addr, int len);

total: 1 errors, 0 warnings, 80 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]