[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 51/64] target-arm: Use clrsb helper
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v4 51/64] target-arm: Use clrsb helper |
Date: |
Fri, 09 Dec 2016 09:52:10 +0000 |
User-agent: |
mu4e 0.9.18; emacs 25.1.90.2 |
Richard Henderson <address@hidden> writes:
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target-arm/helper-a64.c | 10 ----------
> target-arm/helper-a64.h | 2 --
> target-arm/translate-a64.c | 8 ++++----
> 3 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c
> index 77999ff..d9df82c 100644
> --- a/target-arm/helper-a64.c
> +++ b/target-arm/helper-a64.c
> @@ -54,16 +54,6 @@ int64_t HELPER(sdiv64)(int64_t num, int64_t den)
> return num / den;
> }
>
> -uint64_t HELPER(cls64)(uint64_t x)
> -{
> - return clrsb64(x);
> -}
> -
> -uint32_t HELPER(cls32)(uint32_t x)
> -{
> - return clrsb32(x);
> -}
> -
> uint64_t HELPER(rbit64)(uint64_t x)
> {
> return revbit64(x);
> diff --git a/target-arm/helper-a64.h b/target-arm/helper-a64.h
> index d320f96..6f9eaba 100644
> --- a/target-arm/helper-a64.h
> +++ b/target-arm/helper-a64.h
> @@ -18,8 +18,6 @@
> */
> DEF_HELPER_FLAGS_2(udiv64, TCG_CALL_NO_RWG_SE, i64, i64, i64)
> DEF_HELPER_FLAGS_2(sdiv64, TCG_CALL_NO_RWG_SE, s64, s64, s64)
> -DEF_HELPER_FLAGS_1(cls64, TCG_CALL_NO_RWG_SE, i64, i64)
> -DEF_HELPER_FLAGS_1(cls32, TCG_CALL_NO_RWG_SE, i32, i32)
> DEF_HELPER_FLAGS_1(rbit64, TCG_CALL_NO_RWG_SE, i64, i64)
> DEF_HELPER_3(vfp_cmps_a64, i64, f32, f32, ptr)
> DEF_HELPER_3(vfp_cmpes_a64, i64, f32, f32, ptr)
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 12621ff..f73d63b 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -3971,11 +3971,11 @@ static void handle_cls(DisasContext *s, unsigned int
> sf,
> tcg_rn = cpu_reg(s, rn);
>
> if (sf) {
> - gen_helper_cls64(tcg_rd, tcg_rn);
> + tcg_gen_clrsb_i64(tcg_rd, tcg_rn);
> } else {
> TCGv_i32 tcg_tmp32 = tcg_temp_new_i32();
> tcg_gen_extrl_i64_i32(tcg_tmp32, tcg_rn);
> - gen_helper_cls32(tcg_tmp32, tcg_tmp32);
> + tcg_gen_clrsb_i32(tcg_tmp32, tcg_tmp32);
> tcg_gen_extu_i32_i64(tcg_rd, tcg_tmp32);
> tcg_temp_free_i32(tcg_tmp32);
> }
> @@ -7592,7 +7592,7 @@ static void handle_2misc_64(DisasContext *s, int
> opcode, bool u,
> if (u) {
> tcg_gen_clzi_i64(tcg_rd, tcg_rn, 64);
> } else {
> - gen_helper_cls64(tcg_rd, tcg_rn);
> + tcg_gen_clrsb_i64(tcg_rd, tcg_rn);
> }
> break;
> case 0x5: /* NOT */
> @@ -10262,7 +10262,7 @@ static void disas_simd_two_reg_misc(DisasContext *s,
> uint32_t insn)
> if (u) {
> tcg_gen_clzi_i32(tcg_res, tcg_op, 32);
> } else {
> - gen_helper_cls32(tcg_res, tcg_op);
> + tcg_gen_clrsb_i32(tcg_res, tcg_op);
> }
> break;
> case 0x7: /* SQABS, SQNEG */
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 51/64] target-arm: Use clrsb helper,
Alex Bennée <=