qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 1/2] sparc: fix a building error reported by


From: Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH v6 1/2] sparc: fix a building error reported by kbuild
Date: Sat, 10 Dec 2016 08:40:02 +0000




Regards,
-Gonglei


> -----Original Message-----
> From: address@hidden
> [mailto:address@hidden On Behalf Of Sam Ravnborg
> Sent: Saturday, December 10, 2016 5:59 AM
> To: Gonglei (Arei)
> Cc: address@hidden; address@hidden;
> address@hidden; address@hidden;
> address@hidden; Luonengjun; address@hidden;
> address@hidden; Huangweidong (C); Wubin (H); address@hidden;
> Claudio Fontana; address@hidden; address@hidden;
> address@hidden; Zhoujian (jay, Euler); Hanweidong (Randy);
> address@hidden; address@hidden; Xuquan (Quan Xu);
> longpeng; Wanzongshun (Vincent); address@hidden
> Subject: Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild
> 
> Hi Gonglei.
> 
> On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote:
> > >> arch/sparc/include/asm/topology_64.h:44:44:
> > error: implicit declaration of function 'cpu_data'
> > [-Werror=implicit-function-declaration]
> >
> >  #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
> >                                                ^
> > Let's include cpudata.h in topology_64.h.
> >
> > Cc: Sam Ravnborg <address@hidden>
> > Cc: David S. Miller <address@hidden>
> > Cc: address@hidden
> > Suggested-by: Sam Ravnborg <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> Acked-by: Sam Ravnborg <address@hidden>
> 
Thanks.

> > ---
> >  arch/sparc/include/asm/topology_64.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/sparc/include/asm/topology_64.h
> b/arch/sparc/include/asm/topology_64.h
> > index 7b4898a..2255430 100644
> > --- a/arch/sparc/include/asm/topology_64.h
> > +++ b/arch/sparc/include/asm/topology_64.h
> > @@ -4,6 +4,7 @@
> >  #ifdef CONFIG_NUMA
> >
> >  #include <asm/mmzone.h>
> > +#include <asm/cpudata.h>
> 
> Nitpick - if you are going to resend this patch, 

It depends on the maintainer's thought. :)

> then please order the two includes in alphabetic order.
> 
> For two includes this looks like bikeshedding, but when we add
> more having them in a defined arder prevents merge conflicts.
> And makes it readable too.
> 
> We also sometimes order the includes with the longest lines topmost,
> and lines with the ame length are ordered alphabetically.
> But this is not seen so often.
> 

Regards,
-Gonglei



reply via email to

[Prev in Thread] Current Thread [Next in Thread]