[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/19] linux-user: fix settime old value locatio
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 01/19] linux-user: fix settime old value location |
Date: |
Sat, 10 Dec 2016 12:22:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
Le 01/12/2016 à 06:14, Pranith Kumar a écrit :
> From: Marc-André Lureau <address@hidden>
>
> old_value is the 4th argument of timer_settime(), not the 2nd.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Pranith Kumar <address@hidden>
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 7b77503..5bd477a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -12027,7 +12027,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
> arg1,
> target_to_host_itimerspec(&hspec_new, arg3);
> ret = get_errno(
> timer_settime(htimer, arg2, &hspec_new,
> &hspec_old));
> - host_to_target_itimerspec(arg2, &hspec_old);
> + host_to_target_itimerspec(arg4, &hspec_old);
> }
> break;
> }
>
arg4 can be NULL.
You should check for the return value like in timerfd_settime.
In the kernel we have:
if (old_setting && !error &&
copy_to_user(old_setting, &old_spec, sizeof (old_spec)))
error = -EFAULT;
Laurent
- [Qemu-devel] [PATCH v5 00/19] Cleanup of TCG tests, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 02/19] linux-user: fix tcg/mmap test, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 01/19] linux-user: fix settime old value location, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 04/19] tests/tcg: comment unused code, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 03/19] check-help: add some hint to run a single test, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 07/19] linux-test: fix set/getitimer returned timer check, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 06/19] linux-test: fix build, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 08/19] Fix test-i386-fprem compilation, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 09/19] test-i386: modernize vector code v4sf, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 10/19] tests/tcg: Move arm tests to arch specific folder, Pranith Kumar, 2016/12/01
- [Qemu-devel] [PATCH 12/19] tests/tcg: Add tests-tcg hook in Makefile, Pranith Kumar, 2016/12/01