Re: [Qemu-devel] VNC LED state buggy, interop issue

[Gerd Hoffmann]

  Hi,

> The basic problem is that the code right now assumes that XK_Caps_Lock 
> and XK_Num_Lock will toggle their respective states. It is however not 
> assumed that XK_Scroll_Lock toggles any state.

The whole thing is more intended to make sure guest and host have the
same idea about numlock and capslock state, so input works propery, not
so much about making the leds blink properly.

And, yes, it assumes you don't remap capslock + numlock keys to
something else (in the guest).  vnc has an option (lock-key-sync) to
turn off this logic in case it causes problems because the assumtion
doesn't hold for a specific guest.

>   b) Remove the assumption from the code and the protocol.

Patches are welcome.

cheers,
  Gerd