qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilitie


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size
Date: Tue, 13 Dec 2016 13:07:52 +0100

> | This is not the guest returning the size, it is the host renderer
> | library saying how much space it needs ...
> 
>   The library funcion checks 'capset_id' supplied via the 'cmd' object, as 
> 'gc' is initialised from a given command 'cmd'. It sets 'max_size=0' if 
> capset_id != VREND_CAP_SET.

Ah, ok, that makes sense.

I guess we want throw an error (VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER)
in the error case then instead of leaving resp->hdr.type unset.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]