[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] qtest: add ivshmem-test for ppc6
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] qtest: add ivshmem-test for ppc64 |
Date: |
Tue, 13 Dec 2016 13:25:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 13/12/2016 09:55, Thomas Huth wrote:
> On 13.12.2016 09:18, Laurent Vivier wrote:
>>
>>
>> On 13/12/2016 08:55, Markus Armbruster wrote:
>>> Laurent Vivier <address@hidden> writes:
> ...
>>>> @@ -419,7 +426,9 @@ static void test_ivshmem_hotplug(void)
>>>> opts = g_strdup_printf("'shm': '%s', 'size': '1M'", tmpshm);
>>>>
>>>> qpci_plug_device_test("ivshmem", "iv1", PCI_SLOT_HP, opts);
>>>> - qpci_unplug_acpi_device_test("iv1", PCI_SLOT_HP);
>>>> + if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
>>>> + qpci_unplug_acpi_device_test("iv1", PCI_SLOT_HP);
>>>> + }
>>>
>>> Disables unplug test for ppc64.
>
> We don't have acpi on POWER ... but PCI unplug should be possible
> without ACPI, too, shouldn't it? So maybe you could add a PCI unplug
> function for ppc64, too?
Good idea, I will check if we can implement this.
Thanks,
Laurent
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/4] libqos: fix spapr qpci_map(), (continued)