[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y |
Date: |
Tue, 13 Dec 2016 12:40:22 +0000 |
Hi
On Tue, Dec 13, 2016 at 2:18 PM Paolo Bonzini <address@hidden> wrote:
>
>
> On 12/12/2016 23:43, Marc-André Lureau wrote:
> > This will help to split char.c in several units without having to
> > reference them all everywhere.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> > Makefile | 3 ++-
> > Makefile.objs | 4 +++-
> > Makefile.target | 3 +++
> > chardev/Makefile.objs | 2 +-
> > tests/Makefile.include | 4 ++--
> > 5 files changed, 11 insertions(+), 5 deletions(-)
>
> Any reason to do this instead of keeping common-obj-y?
>
>
common-obj-y has a lot of other units, including vl.o, making it not
possible to link with tests/test-char for ex. However, if we changed it to
link with everything except vl.c (or other changes), we may be able to link
with and test spice-qemu-char. The resulting binaries will likely explode
though.
Thanks,
>
> Paolo
>
> --
Marc-André Lureau
- [Qemu-devel] [PATCH 26/54] char-win-stdio: convert to finalize, (continued)
- [Qemu-devel] [PATCH 26/54] char-win-stdio: convert to finalize, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 27/54] char-win: do not override chr_free, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 28/54] char-win: convert to finalize, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 29/54] char-fd: convert to finalize, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 30/54] char: remove chr_free, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 31/54] char: get rid of CharDriver, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 33/54] char: move to chardev/, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 32/54] char: remove class kind field, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 35/54] char: make null_chr_write() the default method, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 36/54] char: move null chardev to its own file, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 37/54] char: move mux to its own file, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 38/54] char: move ringbuf/memory to its own file, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 40/54] char: remove unused READ_RETRIES, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 39/54] char: rename and move to header CHR_READ_BUF_LEN, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 41/54] char: move QIOChannel-related in char-io.h, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 42/54] char: move fd chardev in its own file, Marc-André Lureau, 2016/12/12
- [Qemu-devel] [PATCH 43/54] char: move win chardev base class in its own file, Marc-André Lureau, 2016/12/12