qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y
Date: Tue, 13 Dec 2016 12:40:22 +0000

Hi

On Tue, Dec 13, 2016 at 2:18 PM Paolo Bonzini <address@hidden> wrote:

>
>
> On 12/12/2016 23:43, Marc-André Lureau wrote:
> > This will help to split char.c in several units without having to
> > reference them all everywhere.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  Makefile               | 3 ++-
> >  Makefile.objs          | 4 +++-
> >  Makefile.target        | 3 +++
> >  chardev/Makefile.objs  | 2 +-
> >  tests/Makefile.include | 4 ++--
> >  5 files changed, 11 insertions(+), 5 deletions(-)
>
> Any reason to do this instead of keeping common-obj-y?
>
>
common-obj-y has a lot of other units, including vl.o, making it not
possible to link with tests/test-char for ex. However, if we changed it to
link with everything except vl.c (or other changes), we may be able to link
with and test spice-qemu-char. The resulting binaries will likely explode
though.

Thanks,
>
> Paolo
>
> --
Marc-André Lureau


reply via email to

[Prev in Thread] Current Thread [Next in Thread]