qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX m


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX macros
Date: Tue, 13 Dec 2016 20:16:27 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Stefan Weil <address@hidden> writes:

> Am 13.12.2016 um 13:33 schrieb Laurent Vivier:
>> Le 29/11/2016 à 16:07, Yuval Shaia a écrit :
>>> diff --git a/slirp/slirp.h b/slirp/slirp.h
>>> index a1f3139..3877f66 100644
>>> --- a/slirp/slirp.h
>>> +++ b/slirp/slirp.h
>>> @@ -292,9 +292,4 @@ int tcp_emu(struct socket *, struct mbuf *);
>>>  int tcp_ctl(struct socket *);
>>>  struct tcpcb *tcp_drop(struct tcpcb *tp, int err);
>>>  
>>> -#ifndef _WIN32
>>> -#define min(x,y) ((x) < (y) ? (x) : (y))
>>> -#define max(x,y) ((x) > (y) ? (x) : (y))
>>> -#endif
>>> -
>> It seems the defines have been added because they are already defined
>> for Win32.
>>
>> If we remove them, do we know if MIN()/MAX() are defined for Win32?
>> [CC: host W32 maintainer]
>>
>> Thanks,
>> Laurent
>
> Neither MIN nor MAX are defined in the header files provided with Mingw-w64.

osdep.h provides them, and it's by convention included first by every
.c.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]