qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] VNC LED state buggy, interop issue


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] VNC LED state buggy, interop issue
Date: Wed, 14 Dec 2016 08:31:06 +0100

On Di, 2016-12-13 at 14:10 +0100, Pierre Ossman wrote:
> On 13/12/16 09:06, Gerd Hoffmann wrote:
> >>   b) Remove the assumption from the code and the protocol.
> >
> > Patches are welcome.
> >
> 
> I was just aiming for a consensus on the intended behaviour, rather than 
> fix the bug right now. :)
> But all right, attached patch is an attempt.
> 
> Btw, is there any client that implements this extension yet? I couldn't 
> find anything.
> 
> Regards

Can you send that with git send-email instead of a attachment?
I can quote the patch for commenting then, also various tools expect
patches that way.

Patch looks good.  Commit message is too short.  You are moving the led
tracking from vncstate to vncdisplay, which makes sense, but this shpuld
be explained in the commit message too.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]