qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder
Date: Wed, 14 Dec 2016 09:54:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1


On 14/12/2016 08:59, Thomas Huth wrote:
>>> Right, good catch, thanks! Looks like I did it right in the other
>>> patches and used target/ppc/cpu.h there for example ... I'll fix it for
>>> ARM in the next version of the patch...
>> There is the same problem in: m68k, alpha, mips and sh4.
>>
>> Could you fix them too?
> You mean the #inlcude "cpu-qom.h" statements? I think they are less
> critical since there is no cpu-qom.h in the generic include folder ...
> but yes, better safe than sorry, I'll fix these statements, too.

There is no cpu.h either in include/.  The only path added is include/,
not include/migration/ or include/qom/, so "cpu.h" can only come from
targets.

"git grep include.*cpu.h hw" shows that a wide majority of inclusions
(120 against 9, many of which in hw/arm) doesn't prepend target-foo/. So
the patch looks good to me.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]