|
From: | Pierre Ossman |
Subject: | Re: [Qemu-devel] [PATCH] vnc: track LED state separately |
Date: | Fri, 16 Dec 2016 10:00:24 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 15/12/16 17:41, Gerd Hoffmann wrote:
- caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0; - num = ledstate & QEMU_NUM_LOCK_LED ? 1 : 0; - scr = ledstate & QEMU_SCROLL_LOCK_LED ? 1 : 0; + if (ledstate != vd->ledstate) + return;Hmm? Shouldn't that be (ledstate == vd->ledstate)?
Right, sorry. Brain fart. :) Can you fix that up before commit or do you want a new patch? Regards -- Pierre Ossman Software Development Cendio AB https://cendio.com Teknikringen 8 https://twitter.com/ThinLinc 583 30 Linköping https://facebook.com/ThinLinc Phone: +46-13-214600 https://plus.google.com/+CendioThinLinc A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
[Prev in Thread] | Current Thread | [Next in Thread] |