qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 0/3] MultiCPU changes


From: no-reply
Subject: Re: [Qemu-devel] [RFC 0/3] MultiCPU changes
Date: Fri, 16 Dec 2016 06:07:01 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC 0/3] MultiCPU changes
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a483da8 exec: Allow to change Address Space from board level
2889528 ARM: boot: Add option to skip FDT memory node update
7a4aa5a nvic: Add CPU numebr property

=== OUTPUT BEGIN ===
Checking PATCH 1/3: nvic: Add CPU numebr property...
ERROR: code indent should never use tabs
#82: FILE: hw/intc/armv7m_nvic.c:477:
+^IVMSTATE_UINT32(cpu_id, nvic_state),$

total: 1 errors, 0 warnings, 87 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: ARM: boot: Add option to skip FDT memory node update...
WARNING: line over 80 characters
#44: FILE: hw/arm/boot.c:500:
+                qemu_fdt_setprop_string(fdt, "/memory", "device_type", 
"memory");

total: 0 errors, 1 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: exec: Allow to change Address Space from board level...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]