qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup


From: Liu, Yi L
Subject: Re: [Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup
Date: Mon, 19 Dec 2016 11:25:10 +0000

> -----Original Message-----
> From: Peter Xu [mailto:address@hidden
> Sent: Monday, December 19, 2016 5:23 PM
> To: Liu, Yi L <address@hidden>
> Cc: Tian, Kevin <address@hidden>; Lan, Tianyu <address@hidden>;
> address@hidden; address@hidden; Liu, Yi L <address@hidden>
> Subject: Re: [Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup
> 
> On Sun, Dec 18, 2016 at 04:42:50PM +0800, Liu, Yi L wrote:
> > On Tue, Dec 06, 2016 at 06:36:15PM +0800, Peter Xu wrote:
> > > This RFC series is a continue work for Aviv B.D.'s vfio enablement
> > > series with vt-d. Aviv has done a great job there, and what we still
> > > lack there are mostly the following:
> > >
> > > (1) VFIO got duplicated IOTLB notifications due to splitted VT-d IOMMU
> > >     memory region.
> > >
> > > (2) VT-d still haven't provide a correct replay() mechanism (e.g.,
> > >     when IOMMU domain switches, things will broke).
> > >
> > > Here I'm trying to solve the above two issues.
> > >
> > > (1) is solved by patch 7, (2) is solved by patch 11-12.
> > >
> > > Basically it contains the following:
> > >
> > > patch 1:    picked up from Jason's vhost DMAR series, which is a bugfix
> > >
> > > patch 2-6:  Cleanups/Enhancements for existing vt-d codes (please see
> > >             specific commit message for details, there are patches
> > >             that I thought may be suitable for 2.8 as well, but looks
> > >             like it's too late)
> > >
> > > patch 7:    Solve the issue that vfio is notified more than once for
> > >             IOTLB notifications with Aviv's patches
> > >
> > > patch 8-10: Some trivial memory APIs added for further patches, and
> > >             add customize replay() support for MemoryRegion (I see
> > >             Aviv's latest v7 contains similar replay, I can rebase
> > >             onto that, merely the same thing)
> > >
> > > patch 11:   Provide a valid vt-d replay() callback, using page walk
> > >
> > Peter,
> > Does your patch set based on Aviv's patch? I found the page cannot be
> > applied in my side.
> 
> Hi, Yi,
> 
> This series is based on Aviv's v6 series. If you wanna try it, you may
> want to fetch the tree from:
> 
>  https://github.com/xzpeter/qemu/tree/vtd-vfio-enablement
> 
> So you won't need to bother on the applying.
> 
Aha, looks like you mentioned you github link previously. I forgot it. Would
try it then. I may rebase my current svm work. thx for your contribution.^_^

> >
> > BTW. it may be better if you can split the patches for mis cleanup
> > and the patches for replay/"fix duplicate notify".
> 
> Yes. Here I just want to make sure things are stick together (e.g., to
> test the replay, I will need to use the traces). And I feel it awkward
> to maintain several series upstream while they interact with each
> other. Sorry for the troublesome.
> 
I totally understand what bothers you. It'll be fine. Follow your plan~

Thanks,
Yi L

> Thanks,
> 
> -- peterx

reply via email to

[Prev in Thread] Current Thread [Next in Thread]