[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks |
|
Date: |
Wed, 21 Dec 2016 00:21:55 +0100 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
address@hidden, on Tue 20 Dec 2016 15:15:43 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:
> ERROR: suspect code indent for conditional statements (10, 14)
> #90: FILE: slirp/tftp.c:393:
> + if (blksize > 0) {
> + spt->block_size = MIN(blksize, TFTP_BLOCKSIZE_MAX);
This is a false positive.
Samuel
- [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks, Samuel Thibault, 2016/12/20
- [Qemu-devel] [PULL 2/2] slirp: support dynamic block size for TFTP transfers, Samuel Thibault, 2016/12/20
- [Qemu-devel] [PULL 1/2] slirp, disas: Replace min/max with MIN/MAX macros, Samuel Thibault, 2016/12/20
- Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks, no-reply, 2016/12/20
- Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks,
Samuel Thibault <=
- Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks, Peter Maydell, 2016/12/22