Re: [Qemu-devel] [PATCH v5 4/4] hax: add Darwin support

[Paolo Bonzini]

On 19/12/2016 17:24, Vincent Palatin wrote:
> diff --git a/cpus.c b/cpus.c
> index 0e01791..b8db313 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1264,6 +1264,11 @@ static void qemu_cpu_kick_thread(CPUState *cpu)
>          return;
>      }
>      cpu->thread_kicked = true;
> +#ifdef CONFIG_DARWIN
> +    if (hax_enabled()) {
> +        cpu->exit_request = 1;
> +    }
> +#endif
>      err = pthread_kill(cpu->thread->thread, SIG_IPI);
>      if (err) {
>          fprintf(stderr, "qemu:%s: %s", __func__, strerror(err));

Instead of this, please place the "if" in qemu_cpu_kick before the call
to qemu_cpu_kick_thread.  This way, it will be common to Win32 and Darwin.

Thanks,

Paolo