qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c
Date: Tue, 27 Dec 2016 12:30:05 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] hw/dma: Fix dead code in pl080.c

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
682cfa2 hw/dma: Fix dead code in pl080.c

=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/dma: Fix dead code in pl080.c...
ERROR: spaces required around that '-' (ctx:VxV)
#28: FILE: hw/dma/pl080.c:258:
+        switch ((offset-0x100) >> 2) {
                        ^

ERROR: spaces required around that '-' (ctx:VxV)
#37: FILE: hw/dma/pl080.c:319:
+        switch ((offset-0x100) >> 2) {
                        ^

total: 2 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]