[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V4 03/10] intel_iommu: allocate new key when creatin
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PATCH V4 03/10] intel_iommu: allocate new key when creating new address space |
Date: |
Fri, 30 Dec 2016 18:09:12 +0800 |
We use the pointer to stack for key for new address space, this will break hash
table searching, fixing by g_malloc() a new key instead.
Cc: Michael S. Tsirkin <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Acked-by: Peter Xu <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/i386/intel_iommu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index bf25e04..58ab143 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2327,12 +2327,13 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s,
PCIBus *bus, int devfn)
char name[128];
if (!vtd_bus) {
+ uintptr_t *new_key = g_malloc(sizeof(*new_key));
+ *new_key = (uintptr_t)bus;
/* No corresponding free() */
vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) * \
X86_IOMMU_PCI_DEVFN_MAX);
vtd_bus->bus = bus;
- key = (uintptr_t)bus;
- g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
+ g_hash_table_insert(s->vtd_as_by_busptr, new_key, vtd_bus);
}
vtd_dev_as = vtd_bus->dev_as[devfn];
--
2.7.4
- [Qemu-devel] [PATCH V4 00/10] vhost device IOTLB support, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 02/10] intel_iommu: name vtd address space with devfn, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 01/10] virtio: convert to use DMA api, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 03/10] intel_iommu: allocate new key when creating new address space,
Jason Wang <=
- [Qemu-devel] [PATCH V4 04/10] exec: introduce address_space_get_iotlb_entry(), Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 05/10] intel_iommu: support device iotlb descriptor, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 07/10] acpi: add ATSR for q35, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 06/10] virtio-pci: address space translation service (ATS) support, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 08/10] memory: handle alias for iommu notifier, Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 09/10] memory: handle alias in memory_region_is_iommu(), Jason Wang, 2016/12/30
- [Qemu-devel] [PATCH V4 10/10] vhost_net: device IOTLB support, Jason Wang, 2016/12/30