[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] sd: sdhci: check transfer mode register in
|
From: |
P J P |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] sd: sdhci: check transfer mode register in multi block transfer |
|
Date: |
Wed, 8 Feb 2017 10:47:08 +0530 (IST) |
Hello Alistair,
+-- On Tue, 7 Feb 2017, Alistair Francis wrote --+
| As it doesn't look like we have ever supported an infinite transfer
| and we don't want infinite loops occurring I think we should add an
| unsupported print statement here saying that we don't support infinite
| transfers and then I'm ok with this patch.
Okay, will do.
| > - MASKED_WRITE(s->trnmod, mask, value);
| > + MASKED_WRITE(s->trnmod, mask, value & 0x0037);
|
| What is this change doing?
It is possible to set 's->trnmod' to an invalid value(> 6 bits). Above
mask(0x0037) would limit 'value' to the 6 bits mentioned in the spec.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F