[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.repla
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback |
Date: |
Fri, 10 Feb 2017 13:34:05 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Feb 07, 2017 at 04:28:16PM +0800, Peter Xu wrote:
> Originally we have one memory_region_iommu_replay() function, which is
> the default behavior to replay the translations of the whole IOMMU
> region. However, on some platform like x86, we may want our own replay
> logic for IOMMU regions. This patch add one more hook for IOMMUOps for
> the callback, and it'll override the default if set.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> include/exec/memory.h | 2 ++
> memory.c | 6 ++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 0767888..30b2a74 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -191,6 +191,8 @@ struct MemoryRegionIOMMUOps {
> void (*notify_flag_changed)(MemoryRegion *iommu,
> IOMMUNotifierFlag old_flags,
> IOMMUNotifierFlag new_flags);
> + /* Set this up to provide customized IOMMU replay function */
> + void (*replay)(MemoryRegion *iommu, IOMMUNotifier *notifier);
> };
>
> typedef struct CoalescedMemoryRange CoalescedMemoryRange;
> diff --git a/memory.c b/memory.c
> index 7a4f2f9..9c253cc 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1630,6 +1630,12 @@ void memory_region_iommu_replay(MemoryRegion *mr,
> IOMMUNotifier *n,
> hwaddr addr, granularity;
> IOMMUTLBEntry iotlb;
>
> + /* If the IOMMU has its own replay callback, override */
> + if (mr->iommu_ops->replay) {
> + mr->iommu_ops->replay(mr, n);
> + return;
> + }
> +
> granularity = memory_region_iommu_get_min_page_size(mr);
>
> for (addr = 0; addr < memory_region_size(mr); addr += granularity) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v7 09/17] intel_iommu: vtd_slpt_level_shift check level, (continued)
- [Qemu-devel] [PATCH v7 10/17] memory: add section range info for IOMMU notifier, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 11/17] memory: provide IOMMU_NOTIFIER_FOREACH macro, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 12/17] memory: provide iommu_replay_all(), Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 13/17] memory: introduce memory_region_notify_one(), Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback, Peter Xu, 2017/02/07
- Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback,
David Gibson <=
- [Qemu-devel] [PATCH v7 15/17] intel_iommu: provide its own replay() callback, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 16/17] intel_iommu: allow dynamic switch of IOMMU region, Peter Xu, 2017/02/07
- [Qemu-devel] [PATCH v7 17/17] intel_iommu: enable vfio devices, Peter Xu, 2017/02/07
- Re: [Qemu-devel] [PATCH v7 00/17] VT-d: vfio enablement and misc enhances, Alex Williamson, 2017/02/17