[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock for encryption |
Date: |
Mon, 13 Feb 2017 15:53:36 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 10 Feb 2017 06:09:01 PM CET, Daniel P. Berrange wrote:
> This converts the qcow2 driver to make use of the QCryptoBlock
s/qcow2/qcow/
> APIs for encrypting image content. This is only wired up to
> permit use of the legacy QCow encryption format. Users who wish
> to have the strong LUKS format should switch to qcow2 instead.
> @@ -104,7 +114,18 @@ static int qcow_open(BlockDriverState *bs, QDict
> *options, int flags,
> unsigned int len, i, shift;
> int ret;
> QCowHeader header;
> + QemuOpts *opts = NULL;
> Error *local_err = NULL;
> + QCryptoBlockOpenOptions *crypto_opts = NULL;
> + unsigned int cflags = 0;
> +
> + opts = qemu_opts_create(&qcow_runtime_opts, NULL, 0, &error_abort);
I think you're leaking opts here.
Berto
- [Qemu-devel] [PATCH v4 00/18] Convert QCow[2] to QCryptoBlock & add LUKS support, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 01/18] block: expose crypto option names / defs to other drivers, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 02/18] block: add ability to set a prefix for opt names, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 03/18] qcow: document another weakness of qcow AES encryption, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 04/18] qcow: require image size to be > 1 for new images, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 05/18] iotests: skip 042 with qcow which dosn't support zero sized images, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 06/18] iotests: skip 048 with qcow which doesn't support resize, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 08/18] qcow: make encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/10
- Re: [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock for encryption,
Alberto Garcia <=
- [Qemu-devel] [PATCH v4 07/18] iotests: fix 097 when run with qcow, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 12/18] qcow2: extend specification to cover LUKS encryption, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 14/18] qcow2: add iotests to cover LUKS encryption support, Daniel P. Berrange, 2017/02/10
- [Qemu-devel] [PATCH v4 15/18] iotests: enable tests 134 and 158 to work with qcow (v1), Daniel P. Berrange, 2017/02/10