qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock


From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock for encryption
Date: Mon, 13 Feb 2017 15:53:36 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 10 Feb 2017 06:09:01 PM CET, Daniel P. Berrange wrote:
> This converts the qcow2 driver to make use of the QCryptoBlock

s/qcow2/qcow/

> APIs for encrypting image content. This is only wired up to
> permit use of the legacy QCow encryption format. Users who wish
> to have the strong LUKS format should switch to qcow2 instead.

> @@ -104,7 +114,18 @@ static int qcow_open(BlockDriverState *bs, QDict 
> *options, int flags,
>      unsigned int len, i, shift;
>      int ret;
>      QCowHeader header;
> +    QemuOpts *opts = NULL;
>      Error *local_err = NULL;
> +    QCryptoBlockOpenOptions *crypto_opts = NULL;
> +    unsigned int cflags = 0;
> +
> +    opts = qemu_opts_create(&qcow_runtime_opts, NULL, 0, &error_abort);

I think you're leaking opts here.

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]