[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification |
Date: |
Wed, 15 Feb 2017 19:49:09 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
Ewww, it looks like I have a mingw disagreement I need to fix;
<snip>
> QEMU_CFLAGS -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/pixman-1
> -I$(SRC_PATH)/dtc/libfdt -Werror -mms-bitfields
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include -m64 -mcx16 -mthreads
> -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes
> -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels
> -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body
> -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self
> -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition
> -Wtype-limits -fstack-protector-strong
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/p11-kit-1
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include
> -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/libpng16
<snip>
error: invalid operands to binary - (have 'uint16_t * {aka short unsigned
int *}' and 'short int *')
> /tmp/qemu-test/src/slirp/slirp.c:1280:9: note: in expansion of macro
> 'VMSTATE_UINT16'
> VMSTATE_UINT16(ss.ss_family, union slirp_sockaddr),
> ^
<snip>
error: invalid operands to binary - (have 'uint32_t * {aka unsigned int *}'
and 'u_long * {aka long unsigned int *}')
> /tmp/qemu-test/src/slirp/slirp.c:1281:9: note: in expansion of macro
> 'VMSTATE_UINT32_TEST'
> VMSTATE_UINT32_TEST(sin.sin_addr.s_addr, union slirp_sockaddr,
> ^
> /tmp/qemu-test/src/slirp/slirp.c:1309:9: note: in expansion of macro
> 'VMSTATE_UINT32_TEST'
> VMSTATE_UINT32_TEST(so_faddr.s_addr, struct socket,
> ^
> /tmp/qemu-test/src/slirp/slirp.c:1311:9: note: in expansion of macro
> 'VMSTATE_UINT32_TEST'
> VMSTATE_UINT32_TEST(so_laddr.s_addr, struct socket,
> ^
My mingw headers has:
struct sockaddr_storage {
short ss_family;
char __ss_pad1[_SS_PAD1SIZE];
__MINGW_EXTENSION __int64 __ss_align;
char __ss_pad2[_SS_PAD2SIZE];
};
so the ss_family problem is a signedness problem.
and:
typedef struct in_addr {
union {
struct { u_char s_b1, s_b2, s_b3, s_b4; } S_un_b;
struct { u_short s_w1, s_w2; } S_un_w;
u_long S_addr;
} S_un;
} IN_ADDR, *PIN_ADDR, *LPIN_ADDR;
Hmm, as far as I can tell it's long's are still 32bit; so I'll need
to dig to figure that out.
I'll go and figure it out.
Dave
> /tmp/qemu-test/src/rules.mak:69: recipe for target 'slirp/slirp.o' failed
> make: *** [slirp/slirp.o] Error 1
> make: *** Waiting for unfinished jobs....
> make[1]: *** [docker-run] Error 2
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-t49wmu6l/src'
> make: *** address@hidden Error 2
> === OUTPUT END ===
>
> Test command exited with code: 2
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 1/5] slirp: VMState conversion; tcpcb, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 2/5] slirp: VMStatify sbuf, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 3/5] slirp: Common lhost/fhost union, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 5/5] slirp: VMStatify remaining except for loop, Dr. David Alan Gilbert (git), 2017/02/15
- Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification, no-reply, 2017/02/15
- Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification, no-reply, 2017/02/15
- Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification,
Dr. David Alan Gilbert <=