Re: [Qemu-devel] [PATCH v7 8/8] MAINTAINERS: Add VM Generation ID entry

[Laszlo Ersek]

On 02/16/17 07:18, address@hidden wrote:
> From: Ben Warren <address@hidden>
> 
> Also add BIOS tables entry
> 
> Signed-off-by: Ben Warren <address@hidden>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fb57d8e..e2e4b4f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -909,6 +909,7 @@ F: hw/acpi/*
>  F: hw/smbios/*
>  F: hw/i386/acpi-build.[hc]
>  F: hw/arm/virt-acpi-build.c
> +F: tests/bios-tables-test.c

(1) Please add:

tests/acpi-utils.c
tests/acpi-utils.h

(2) I think this hunk belongs to

[PATCH v7 6/8] tests: Move reusable ACPI code into a utility file

or else an entirely separate patch.

>  
>  ppc4xx
>  M: Alexander Graf <address@hidden>
> @@ -1123,6 +1124,13 @@ F: hw/nvram/chrp_nvram.c
>  F: include/hw/nvram/chrp_nvram.h
>  F: tests/prom-env-test.c
>  
> +VM Generation ID
> +M: Ben Warren <address@hidden>
> +S: Maintained
> +F: hw/acpi/vmgenid.c
> +F: include/hw/acpi/vmgenid.h
> +F: tests/vmgenid-test.c
> +

(3) Please add:

docs/specs/vmgenid.txt
stubs/vmgenid.c

With those changes, for this patch:

Reviewed-by: Laszlo Ersek <address@hidden>

Thanks
Laszlo


>  Subsystems
>  ----------
>  Audio
>