[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros |
Date: |
Fri, 17 Feb 2017 14:51:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:26 AM, Markus Armbruster wrote:
> Writing QEMU_STRTOSZ_DEFSUFFIX_* instead of '*' gains nothing. Get
> rid of these eyesores.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> util/cutils.c | 28 ++++++++++------------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/util/cutils.c b/util/cutils.c
> index ef658bb..4a290ea 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -178,30 +178,22 @@ int fcntl_setfl(int fd, int flag)
> }
> #endif
>
> -#define QEMU_STRTOSZ_DEFSUFFIX_EB 'E'
> -#define QEMU_STRTOSZ_DEFSUFFIX_PB 'P'
> -#define QEMU_STRTOSZ_DEFSUFFIX_TB 'T'
> -#define QEMU_STRTOSZ_DEFSUFFIX_GB 'G'
> -#define QEMU_STRTOSZ_DEFSUFFIX_MB 'M'
> -#define QEMU_STRTOSZ_DEFSUFFIX_KB 'K'
> -#define QEMU_STRTOSZ_DEFSUFFIX_B 'B'
> -
> static int64_t suffix_mul(char suffix, int64_t unit)
> {
> switch (qemu_toupper(suffix)) {
> - case QEMU_STRTOSZ_DEFSUFFIX_B:
> + case 'B':
> return 1;
> - case QEMU_STRTOSZ_DEFSUFFIX_KB:
Oh, my comments on 16/24 were a bit premature; those macros were used.
But I'm definitely in favor of this cleanup!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/24] QemuOpts util/cutils: Fix and clean up number conversions, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() invalid input, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 19/24] tests/test-cutils: Drop suffix from test_qemu_strtosz_simple(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 14/24] util/cutils: New qemu_strtosz_metric(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 18/24] tests/test-cutils: Use qemu_strtosz() more often, Markus Armbruster, 2017/02/14