[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new bloc
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" |
Date: |
Mon, 20 Feb 2017 14:49:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 20/02/2017 11:07, Daniel P. Berrange wrote:
>> + if (qemu_uuid_is_null(&qemu_uuid)) {
> This is the wrong check - QEMU provides a 'qemu_uuid_set' boolean
> to determine if 'qemu_uuid' is set or not. If it is not set, then
> the code should return an error, not use a hardcoded uuid.
Or otherwise that hardcoded uuid should be all zeroes (UUID_NONE).
Paolo
>> + if (iio_init(QNIO_VERSION, vxhs_iio_callback, VXHS_UUID_DEF)) {
>> + return -ENODEV;
>> + }