[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 40/54] block: BdrvChildRole.attach/detach() call
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 40/54] block: BdrvChildRole.attach/detach() callbacks |
Date: |
Sat, 25 Feb 2017 13:29:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 21.02.2017 15:58, Kevin Wolf wrote:
> Backing files are somewhat special compared to other kinds of children
> because they are attached and detached using bdrv_set_backing_hd()
> rather than the normal set of functions, which does a few more things
> like setting backing blockers, toggling the BDRV_O_NO_BACKING flag,
> setting parent_bs->backing_file, etc.
>
> These special features are a reason why change_parent_backing_link()
> can't handle backing files yet. With abstracting the additional features
> into .attach/.detach callbacks, we get a step closer to a function that
> can actually deal with this.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 94
> +++++++++++++++++++++++++++++------------------
> include/block/block_int.h | 3 ++
> 2 files changed, 62 insertions(+), 35 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 39/54] block: Fix pending requests check in bdrv_append(), (continued)
- [Qemu-devel] [PATCH 36/54] commit: Use real permissions in commit block job, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 41/54] block: Allow backing file links in change_parent_backing_link(), Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 38/54] backup: Use real permissions in backup block job, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 44/54] mirror: Add filter-node-name to blockdev-mirror, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 40/54] block: BdrvChildRole.attach/detach() callbacks, Kevin Wolf, 2017/02/21
- Re: [Qemu-devel] [PATCH 40/54] block: BdrvChildRole.attach/detach() callbacks,
Max Reitz <=
- [Qemu-devel] [PATCH 43/54] stream: Use real permissions in streaming block job, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 42/54] mirror: Use real permissions in mirror/active commit block job, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 46/54] hmp: Request permissions in qemu-io, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 45/54] commit: Add filter-node-name to block-commit, Kevin Wolf, 2017/02/21
- [Qemu-devel] [PATCH 49/54] tests: Remove FIXME comments, Kevin Wolf, 2017/02/21