[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *lis
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *list reliably |
Date: |
Sat, 25 Feb 2017 09:56:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> qobject_input_start_struct() sets *list, except when it fails because
> qobject_input_get_object() fails, i.e. the input object doesn't exist.
>
> All the other input visitor start_struct(), start_list(),
> start_alternate() always set *obj / *list.
>
> Change qobject_input_start_struct() to match.
I thought I'd caught all those. Thanks for the cleanup.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qapi/qobject-input-visitor.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 10/21] qapi: Clean up after commit 3d344c2, (continued)
- [Qemu-devel] [PATCH 10/21] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 13/21] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 21/21] qapi: Improve qobject visitor documentation, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 12/21] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 18/21] tests-qobject-input-strict: Merge into test-qobject-input-visitor, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/02/23
- Re: [Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *list reliably,
Eric Blake <=
- [Qemu-devel] [PATCH 17/21] qapi: Drop unused non-strict qobject input visitor, Markus Armbruster, 2017/02/23
Re: [Qemu-devel] [PATCH 00/21] qapi: QMP dispatch and input visitor work, no-reply, 2017/02/24