[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle
|
From: |
Michal Marek |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle |
|
Date: |
Sun, 26 Feb 2017 00:30:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 |
Dne 25.2.2017 v 21:39 Michal Marek napsal(a):
> Dne 25.2.2017 v 01:05 Richard Henderson napsal(a):
>> On 02/25/2017 12:44 AM, Michal Marek wrote:
>>> +static int do_stfle(CPUS390XState *env, uint64_t addr, int len)
>>> +{
>>> + S390CPU *cpu = s390_env_get_cpu(env);
>>> + uint8_t data[64];
>>
>> S390FeatBitmap or S390FeatInit? Or even a sizeof?
>> Hard coding 64 certainly doesn't seem right.
>
> I will change it to something more sensible.
I changed it to 2k, which is the maximum that the STFLE instruction can
store. I did not use S390FeatBitmap or S390FeatInit, as the
qemu-internal feature bit assignments differ from the PoO facility bit
assignments.
Michal