[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/11] i386: Rename X86CPU::host_features to X86CPU::
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 03/11] i386: Rename X86CPU::host_features to X86CPU::max_features |
Date: |
Mon, 27 Feb 2017 13:24:53 -0300 |
Rename the field and add a small comment to make its purpose
clearer.
Message-Id: <address@hidden>
Tested-by: Jiri Denemark <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
target/i386/cpu.h | 2 +-
target/i386/cpu.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 8df124f332..5f75ab1b15 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1211,7 +1211,7 @@ struct X86CPU {
bool enforce_cpuid;
bool expose_kvm;
bool migratable;
- bool host_features;
+ bool max_features; /* Enable all supported features automatically */
uint32_t apic_id;
/* Enables publishing of TSC increment and Local APIC bus frequencies to
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 8efe4de89e..87affbfcd6 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -1583,7 +1583,7 @@ static void host_x86_cpu_initfn(Object *obj)
/* We can't fill the features array here because we don't know yet if
* "migratable" is true or false.
*/
- cpu->host_features = true;
+ cpu->max_features = true;
/* If KVM is disabled, x86_cpu_realizefn() will report an error later */
if (kvm_enabled()) {
@@ -3101,12 +3101,12 @@ static void x86_cpu_load_features(X86CPU *cpu, Error
**errp)
GList *l;
Error *local_err = NULL;
- /*TODO: cpu->host_features incorrectly overwrites features
+ /*TODO: cpu->max_features incorrectly overwrites features
* set using "feat=on|off". Once we fix this, we can convert
* plus_features & minus_features to global properties
* inside x86_cpu_parse_featurestr() too.
*/
- if (cpu->host_features) {
+ if (cpu->max_features) {
for (w = 0; w < FEATURE_WORDS; w++) {
env->features[w] =
x86_cpu_get_supported_feature_word(w, cpu->migratable);
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 01/11] i386: Unset cannot_destroy_with_object_finalize_yet on "host" model, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 02/11] i386: Add ordering field to CPUClass, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 03/11] i386: Rename X86CPU::host_features to X86CPU::max_features,
Eduardo Habkost <=
- [Qemu-devel] [PULL 05/11] qapi-schema: Comment about full expansion of non-migration-safe models, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 04/11] i386: Reorganize and document CPUID initialization steps, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 06/11] i386: Create "max" CPU model, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 07/11] i386: Make "max" model not use any host CPUID info on TCG, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 08/11] i386: Don't set CPUClass::cpu_def on "max" model, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 11/11] i386: Improve query-cpu-model-expansion full mode, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 09/11] i386: Define static "base" CPU model, Eduardo Habkost, 2017/02/27
- [Qemu-devel] [PULL 10/11] i386: Implement query-cpu-model-expansion QMP command, Eduardo Habkost, 2017/02/27
- Re: [Qemu-devel] [PULL 00/11] x86 queue, 2017-02-27, Peter Maydell, 2017/02/27