[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused |
Date: |
Fri, 22 Feb 2019 08:53:20 +0100 |
From: Marc-André Lureau <address@hidden>
spice_server_vm_start/stop() was added to help migration state (commit
f5bb039c6d97ef3e664094eab3c9a4dc1824ed73).
However, a paused VM could keep running the spice server. This will
allow a Spice client to keep sending commands to a spice chardev. This
allows to stop/cont a VM from a Spice monitor port. Character
devices (vdagent/usb/smartcard/..) should not read from Spice when the
VM is paused.
Signed-off-by: Marc-André Lureau <address@hidden>
Tested-by: Victor Toso <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/spice-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 1cc996027719..4d384974ca34 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -628,7 +628,7 @@ static void vm_change_state_handler(void *opaque, int
running,
{
if (running) {
qemu_spice_display_start();
- } else {
+ } else if (state != RUN_STATE_PAUSED) {
qemu_spice_display_stop();
}
}
--
2.9.3
- [Qemu-devel] [PULL 00/15] Ui 20190222 patches, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 04/15] ui/gtk: Fix the license information, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 13/15] qapi: document DisplayType enum, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 02/15] spice: set device address and device display ID in QXL interface, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 03/15] sdl2: drop qemu_input_event_send_key_qcode call, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 14/15] spice: use a default name for the server, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 10/15] char: move SpiceChardev and open_spice_port() to spice.h header, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 07/15] spice: avoid spice runtime assert, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 11/15] char: register spice ports after spice started, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 08/15] spice: merge options lists, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 05/15] char/spice: trigger HUP event, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 01/15] kbd-state: don't block auto-repeat events, Gerd Hoffmann, 2019/02/22