[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [RFC PATCH v5 22/33] Hexagon (target/hexagon) generater phase 4 - de
From: |
Taylor Simpson |
Subject: |
RE: [RFC PATCH v5 22/33] Hexagon (target/hexagon) generater phase 4 - decode tree |
Date: |
Wed, 2 Dec 2020 01:46:55 +0000 |
> -----Original Message-----
> From: Alessandro Di Federico <ale.qemu@rev.ng>
> Sent: Thursday, November 19, 2020 4:54 PM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> at.org@qualcomm.com; laurent@vivier.eu; Brian Cain <bcain@quicinc.com>
> Subject: Re: [RFC PATCH v5 22/33] Hexagon (target/hexagon) generater
> phase 4 - decode tree
>
> Is there any specific reason why (here and elsewhere) you use
> `StringIO` instead of writing to the file directly?
>
> I'd expect something like:
>
> ```
> if __name__ == '__main__':
> with open(sys.argv[1], 'w') as f:
> print_tree(f, dectree_normal)
> print_tree(f, dectree_16bit)
> if subinsn_groupings:
> print_tree(f, dectree_subinsn_groupings)
> for (name, dectree_subinsn) in sorted(dectree_subinsns.items()):
> print_tree(f, dectree_subinsn)
> for (name, dectree_ext) in sorted(dectree_extensions.items()):
> print_tree(f, dectree_ext)
> print_match_info(f)
> print_op_info(f)
> ```
OK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- RE: [RFC PATCH v5 22/33] Hexagon (target/hexagon) generater phase 4 - decode tree,
Taylor Simpson <=