Re: [PATCH v2 5/8] libvhost-user: make it a meson subproject

[Stefan Hajnoczi]

On Wed, Nov 25, 2020 at 02:06:37PM +0400, marcandre.lureau@redhat.com wrote:
> diff --git a/meson.build b/meson.build
> index 5062407c70..1b14998691 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1476,7 +1476,12 @@ trace_events_subdirs += [
>    'util',
>  ]
>  
> -subdir('contrib/libvhost-user')
> +vhost_user = not_found
> +if 'CONFIG_VHOST_USER' in config_host
> +  libvhost_user = subproject('libvhost-user')
> +  vhost_user = libvhost_user.get_variable('vhost_user_dep')
> +endif
> +
>  subdir('qapi')
>  subdir('qobject')
>  subdir('stubs')

I wonder if qemu-system-ARCH and qemu-storage-daemon targets will break
with ./configure --disable-vhost-user because of util/meson.build:

  util_ss.add(when: 'CONFIG_LINUX', if_true: [
    files('vhost-user-server.c'), vhost_user
  ])

Stefan

signature.asc
Description: PGP signature