[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes invalid inputs |
Date: |
Mon, 7 Dec 2020 11:31:44 +0000 |
On Thu, Nov 12, 2020 at 04:40:07PM +0100, Max Reitz wrote:
> On 11.11.20 13:43, Stefan Hajnoczi wrote:
> > Exercise input validation code paths in
> > block/export/vhost-user-blk-server.c.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > block/export/vhost-user-blk-server.c | 4 +-
> > tests/qtest/vhost-user-blk-test.c | 124 +++++++++++++++++++++++++++
> > 2 files changed, 126 insertions(+), 2 deletions(-)
> >
> > diff --git a/block/export/vhost-user-blk-server.c
> > b/block/export/vhost-user-blk-server.c
> > index 3295d3c951..d88e41714d 100644
> > --- a/block/export/vhost-user-blk-server.c
> > +++ b/block/export/vhost-user-blk-server.c
> > @@ -248,8 +248,8 @@ static void coroutine_fn vu_blk_virtio_process_req(void
> > *opaque)
> > break;
> > }
> > - req->in->status = vu_blk_discard_write_zeroes(vexp, elem->out_sg,
> > - out_num, type);
> > + req->in->status = vu_blk_discard_write_zeroes(vexp, out_iov,
> > out_num,
> > + type);
> > break;
> > }
> > default:
>
> Looks like this hunk should be squashed into the previous patch. I think
> that would lift my confusion.
Thanks, will fix.
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes invalid inputs,
Stefan Hajnoczi <=