Re: [RFC v9 08/32] i386: move TCG accel files into tcg/

[Claudio Fontana]

On 12/9/20 10:30 AM, Alex Bennée wrote:
> 
> Claudio Fontana <cfontana@suse.de> writes:
> 
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> ---
>>  target/i386/meson.build             | 14 +-------------
>>  target/i386/{ => tcg}/bpt_helper.c  |  0
>>  target/i386/{ => tcg}/cc_helper.c   |  0
>>  target/i386/{ => tcg}/excp_helper.c |  0
>>  target/i386/{ => tcg}/fpu_helper.c  |  0
>>  target/i386/{ => tcg}/int_helper.c  |  0
>>  target/i386/{ => tcg}/mem_helper.c  |  0
>>  target/i386/tcg/meson.build         | 13 +++++++++++++
>>  target/i386/{ => tcg}/misc_helper.c |  0
>>  target/i386/{ => tcg}/mpx_helper.c  |  0
>>  target/i386/{ => tcg}/seg_helper.c  |  0
>>  target/i386/{ => tcg}/smm_helper.c  |  0
>>  target/i386/{ => tcg}/svm_helper.c  |  0
>>  target/i386/{ => tcg}/tcg-stub.c    |  0
>>  target/i386/{ => tcg}/translate.c   |  0
>>  15 files changed, 14 insertions(+), 13 deletions(-)
>>  rename target/i386/{ => tcg}/bpt_helper.c (100%)
>>  rename target/i386/{ => tcg}/cc_helper.c (100%)
>>  rename target/i386/{ => tcg}/excp_helper.c (100%)
>>  rename target/i386/{ => tcg}/fpu_helper.c (100%)
>>  rename target/i386/{ => tcg}/int_helper.c (100%)
>>  rename target/i386/{ => tcg}/mem_helper.c (100%)
>>  create mode 100644 target/i386/tcg/meson.build
>>  rename target/i386/{ => tcg}/misc_helper.c (100%)
>>  rename target/i386/{ => tcg}/mpx_helper.c (100%)
>>  rename target/i386/{ => tcg}/seg_helper.c (100%)
>>  rename target/i386/{ => tcg}/smm_helper.c (100%)
>>  rename target/i386/{ => tcg}/svm_helper.c (100%)
>>  rename target/i386/{ => tcg}/tcg-stub.c (100%)
>>  rename target/i386/{ => tcg}/translate.c (100%)
> 
> I noticed target/i386/helper-tcg.h is still in the main directory. It

This is something to fix in 

i386: move TCG cpu class initialization out of helper.c

will do, thanks!


> maybe be a straggler that is harder to separate - if so might be worth
> mentioning in the commit message. Otherwise:
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>