[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops
From: |
Claudio Fontana |
Subject: |
Re: [RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops |
Date: |
Wed, 9 Dec 2020 15:43:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 12/9/20 10:31 AM, Philippe Mathieu-Daudé wrote:
> On 12/8/20 8:48 PM, Claudio Fontana wrote:
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> ---
> ...
>> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
>> index 6b9b72e785..0cc0927738 100644
>> --- a/include/hw/core/tcg-cpu-ops.h
>> +++ b/include/hw/core/tcg-cpu-ops.h
>
> Missing (for MemTxAttrs/MemTxResult):
>
> #include "exec/memattrs.h"
right, this is included only from cpu.h though, which already does it, should
we still repeat the include here?
Thanks,
Claudio
>
>> @@ -40,6 +40,15 @@ typedef struct TcgCpuOperations {
>> /** @do_interrupt: Callback for interrupt handling. */
>> void (*do_interrupt)(CPUState *cpu);
>>
>> + /**
>> + * @do_transaction_failed: Callback for handling failed memory
>> transactions
>> + * (ie bus faults or external aborts; not MMU faults)
>> + */
>> + void (*do_transaction_failed)(CPUState *cpu, hwaddr physaddr, vaddr
>> addr,
>> + unsigned size, MMUAccessType access_type,
>> + int mmu_idx, MemTxAttrs attrs,
>> + MemTxResult response, uintptr_t retaddr);
>> +
> ...
>
>
- Re: [RFC v9 18/32] cpu: Move synchronize_from_tb() to tcg_ops, (continued)
[RFC v9 19/32] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/08
[RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2020/12/08
Re: [RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops, Alex Bennée, 2020/12/09
[RFC v9 23/32] cpu: move cc->do_interrupt to tcg_ops, Claudio Fontana, 2020/12/08
[RFC v9 21/32] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2020/12/08
[RFC v9 22/32] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2020/12/08
[RFC v9 26/32] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2020/12/08