[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h' |
|
Date: |
Wed, 9 Dec 2020 09:25:46 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/9/20 3:17 AM, Philippe Mathieu-Daudé wrote:
> Hi Richard,
>
> On 12/9/20 1:03 AM, Richard Henderson wrote:
> In a previous version I tried to directly pass from
>
> static void gen_msa(DisasContext *ctx) ...
>
> to:
>
> static bool trans_MSA(DisasContext *ctx, arg_MSA *a) ...
>
> without declaring the intermediate 'void gen_msa(DisasContext)'
> in "translate.h" (this patch). The result was less trivial to
> review, so I went back to using an intermediate patch for
> simplicity.
>
> Is that what you were thinking about?
Yes, exactly that.
r~
- [PATCH 09/17] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ(), (continued)
- [PATCH 09/17] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ(), Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 10/17] target/mips: Rename msa_helper.c as mod-msa_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 11/17] target/mips: Move msa_reset() to mod-msa_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 12/17] target/mips: Extract MSA helpers from op_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h', Philippe Mathieu-Daudé, 2020/12/07
[PATCH 16/17] target/mips: Introduce decode tree bindings for MSA opcodes, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 13/17] target/mips: Extract MSA helper definitions, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 15/17] target/mips: Extract MSA translation routines, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 17/17] target/mips: Use decode_msa32() generated from decodetree, Philippe Mathieu-Daudé, 2020/12/07
Re: [PATCH 00/17] target/mips: Convert MSA ASE to decodetree, Philippe Mathieu-Daudé, 2020/12/07
Re: [PATCH 00/17] target/mips: Convert MSA ASE to decodetree, Jiaxun Yang, 2020/12/08