[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 6/6] gitlab: add --without-default-features build
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH v1 6/6] gitlab: add --without-default-features build |
|
Date: |
Thu, 10 Dec 2020 06:51:53 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 09/12/2020 19.32, Alex Bennée wrote:
>
> Thomas Huth <thuth@redhat.com> writes:
>
>> On 09/12/2020 18.00, Alex Bennée wrote:
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> .gitlab-ci.yml | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> index 878d114d40..f87584ca8f 100644
>>> --- a/.gitlab-ci.yml
>>> +++ b/.gitlab-ci.yml
>>> @@ -441,6 +441,13 @@ build-without-default-devices:
>>> IMAGE: debian-amd64
>>> CONFIGURE_ARGS: --without-default-devices --disable-user
>>>
>>> +build-without-default-features:
>>> + <<: *native_build_job_definition
>>> + variables:
>>> + IMAGE: centos8
>>> + CONFIGURE_ARGS: --without-default-devices --without-default-features
>>> --disable-user
>>> + MAKE_CHECK_ARGS: check-unit
>>
>> I wonder whether we'd rather want to check without
>> "--without-default-devices" here to see whether all code compiles fine with
>> "--without-default-features" ... ?
>
> Yeah at the moment the full-fat without everything doesn't achieve much.
> So how about I swap the IMAGE around with the previous build and drop
> the --without-default-devices?
Sounds like a plan, thanks!
Thomas