[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 24/32] cpu: move cc->transaction_failed to tcg_ops
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v10 24/32] cpu: move cc->transaction_failed to tcg_ops |
Date: |
Thu, 10 Dec 2020 13:59:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/10/20 1:12 PM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> include/hw/core/cpu.h | 18 +++++++-----------
> include/hw/core/tcg-cpu-ops.h | 10 ++++++++++
> hw/mips/jazz.c | 9 +++++++--
> target/alpha/cpu.c | 2 +-
> target/arm/cpu.c | 4 ++--
> target/m68k/cpu.c | 2 +-
> target/microblaze/cpu.c | 2 +-
> target/mips/cpu.c | 2 +-
> target/riscv/cpu.c | 2 +-
> target/sparc/cpu.c | 2 +-
> target/xtensa/cpu.c | 2 +-
> 11 files changed, 33 insertions(+), 22 deletions(-)
...
> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
> index a7387b5c39..3cc2733410 100644
> --- a/include/hw/core/tcg-cpu-ops.h
> +++ b/include/hw/core/tcg-cpu-ops.h
> @@ -11,6 +11,7 @@
> #define TCG_CPU_OPS_H
>
> #include "hw/core/cpu.h"
> +#include "exec/memattrs.h"
>
> /**
> * struct TcgCpuOperations: TCG operations specific to a CPU class
> @@ -41,6 +42,15 @@ typedef struct TcgCpuOperations {
> /** @do_interrupt: Callback for interrupt handling. */
> void (*do_interrupt)(CPUState *cpu);
>
Do we want to restrict this handler to system-mode?
#ifdef CONFIG_SOFTMMU
> + /**
> + * @do_transaction_failed: Callback for handling failed memory
> transactions
> + * (ie bus faults or external aborts; not MMU faults)
> + */
> + void (*do_transaction_failed)(CPUState *cpu, hwaddr physaddr, vaddr addr,
> + unsigned size, MMUAccessType access_type,
> + int mmu_idx, MemTxAttrs attrs,
> + MemTxResult response, uintptr_t retaddr);
#endif
> /**
> * @tlb_fill: Handle a softmmu tlb miss or user-only address fault
> *
...
- [PATCH v10 10/32] i386: move TCG cpu class initialization out of helper.c, (continued)
- [PATCH v10 10/32] i386: move TCG cpu class initialization out of helper.c, Claudio Fontana, 2020/12/10
- [PATCH v10 13/32] tcg: Make CPUClass.debug_excp_handler optional, Claudio Fontana, 2020/12/10
- [PATCH v10 14/32] cpu: Remove unnecessary noop methods, Claudio Fontana, 2020/12/10
- [PATCH v10 17/32] accel/tcg: split TCG-only code from cpu_exec_realizefn, Claudio Fontana, 2020/12/10
- [PATCH v10 12/32] tcg: make CPUClass.cpu_exec_* optional, Claudio Fontana, 2020/12/10
- [PATCH v10 15/32] cpu: Introduce TCGCpuOperations struct, Claudio Fontana, 2020/12/10
- [PATCH v10 16/32] target/riscv: remove CONFIG_TCG, as it is always TCG, Claudio Fontana, 2020/12/10
- [PATCH v10 18/32] cpu: Move synchronize_from_tb() to tcg_ops, Claudio Fontana, 2020/12/10
- [PATCH v10 22/32] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2020/12/10
- [PATCH v10 24/32] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2020/12/10
- Re: [PATCH v10 24/32] cpu: move cc->transaction_failed to tcg_ops,
Philippe Mathieu-Daudé <=
- [PATCH v10 25/32] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2020/12/10
[PATCH v10 19/32] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/10
[PATCH v10 20/32] cpu: Move tlb_fill to tcg_ops, Claudio Fontana, 2020/12/10
[PATCH v10 21/32] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2020/12/10
[PATCH v10 30/32] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2020/12/10