[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 14/25] cpu: Remove unnecessary noop methods
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v11 14/25] cpu: Remove unnecessary noop methods |
Date: |
Fri, 11 Dec 2020 12:05:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/11/20 9:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
Either add:
"In the previous commits we made cpu_exec_* and
debug_excp_handler handlers optional, we can now
remove these no-op handlers."
Or squash in each commit...
Anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/core/cpu.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/hw/core/cpu.c b/hw/core/cpu.c
> index 576fa1d7ba..994a12cb35 100644
> --- a/hw/core/cpu.c
> +++ b/hw/core/cpu.c
> @@ -199,15 +199,6 @@ static bool cpu_common_virtio_is_big_endian(CPUState
> *cpu)
> return target_words_bigendian();
> }
>
> -static void cpu_common_noop(CPUState *cpu)
> -{
> -}
> -
> -static bool cpu_common_exec_interrupt(CPUState *cpu, int int_req)
> -{
> - return false;
> -}
> -
> #if !defined(CONFIG_USER_ONLY)
> GuestPanicInformation *cpu_get_crash_info(CPUState *cpu)
> {
> @@ -410,11 +401,7 @@ static void cpu_class_init(ObjectClass *klass, void
> *data)
> k->gdb_read_register = cpu_common_gdb_read_register;
> k->gdb_write_register = cpu_common_gdb_write_register;
> k->virtio_is_big_endian = cpu_common_virtio_is_big_endian;
> - k->debug_excp_handler = cpu_common_noop;
> k->debug_check_watchpoint = cpu_common_debug_check_watchpoint;
> - k->cpu_exec_enter = cpu_common_noop;
> - k->cpu_exec_exit = cpu_common_noop;
> - k->cpu_exec_interrupt = cpu_common_exec_interrupt;
> k->adjust_watchpoint_address = cpu_adjust_watchpoint_address;
> set_bit(DEVICE_CATEGORY_CPU, dc->categories);
> dc->realize = cpu_common_realizefn;
>
- Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops, (continued)
- [PATCH v11 10/25] i386: move TCG cpu class initialization out of helper.c, Claudio Fontana, 2020/12/11
- [PATCH v11 17/25] accel/tcg: split TCG-only code from cpu_exec_realizefn, Claudio Fontana, 2020/12/11
- [PATCH v11 24/25] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2020/12/11
- [PATCH v11 14/25] cpu: Remove unnecessary noop methods, Claudio Fontana, 2020/12/11
- Re: [PATCH v11 14/25] cpu: Remove unnecessary noop methods,
Philippe Mathieu-Daudé <=
- [PATCH v11 20/25] cpu: Move tlb_fill to tcg_ops, Claudio Fontana, 2020/12/11
- [PATCH v11 22/25] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2020/12/11
- [PATCH v11 23/25] cpu: move cc->do_interrupt to tcg_ops, Claudio Fontana, 2020/12/11
- [PATCH v11 19/25] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/11
- [PATCH v11 25/25] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2020/12/11