[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallth
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements |
|
Date: |
Fri, 11 Dec 2020 15:37:57 +0000 |
On Fri, 11 Dec 2020 at 15:24, Thomas Huth <thuth@redhat.com> wrote:
>
> When compiling with -Werror=implicit-fallthrough, gcc complains about
> missing fallthrough annotations in this file. Looking at the code,
> the fallthrough is indeed wanted here, but instead of adding the
> annotations, it can be done more efficiently by simply calculating
> the offset with a subtraction instead of increasing a local variable
> one by one.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, Thomas Huth, 2020/12/11
- [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7, Thomas Huth, 2020/12/11
- [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements, Thomas Huth, 2020/12/11
- Re: [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements,
Peter Maydell <=
- [PATCH 02/12] target/unicore32/translate: Add missing fallthrough annotations, Thomas Huth, 2020/12/11
- [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Thomas Huth, 2020/12/11
- [PATCH 07/12] accel/tcg/user-exec: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 08/12] target/sparc/translate: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 10/12] tcg/optimize: Add fallthrough annotations, Thomas Huth, 2020/12/11