Re: [PATCH v4 6/6] linux-user: Add support for MIPS Loongson 2F/3A

[Philippe Mathieu-Daudé]

On 12/7/20 11:43 PM, Philippe Mathieu-Daudé wrote:
> Userland ELF binaries using Loongson SIMD instructions have the
> HWCAP_LOONGSON_MMI bit set [1].
> Binaries compiled for LLoongson 3A [2] have the HWCAP_LOONGSON_EXT

Bah... Yet another typo "LLoongson" -> "Loongson".

> bit set for the LQ / SQ instructions.
> 
> [1] commit 8e2d5831e4b ("target/mips: Legalize Loongson insn flags")
> [2] commit af868995e1b ("target/mips: Add Loongson-3 CPU definition")
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/elfload.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 0836e72b5ac..a64050713f2 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1024,6 +1024,8 @@ static uint32_t get_elf_hwcap(void)
>      GET_FEATURE_REG_EQU(CP0_Config0, CP0C0_AR, CP0C0_AR_LENGTH,
>                          2, HWCAP_MIPS_R6);
>      GET_FEATURE_REG_SET(CP0_Config3, 1 << CP0C3_MSAP, HWCAP_MIPS_MSA);
> +    GET_FEATURE_INSN(ASE_LMMI, HWCAP_LOONGSON_MMI);
> +    GET_FEATURE_INSN(ASE_LEXT, HWCAP_LOONGSON_EXT);
>  
>      return hwcaps;
>  }
>