Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property

[Igor Mammedov]

On Fri, 11 Dec 2020 17:05:14 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Use the DEFINE_PROP macro (which will set extra fields in the
> struct) instead of initializing a Property struct manually.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> This is a new patch added in v2 of the series
> ---
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> Cc: qemu-devel@nongnu.org
> ---
>  target/sparc/cpu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
> index 6a3299041f..92534bcd18 100644
> --- a/target/sparc/cpu.c
> +++ b/target/sparc/cpu.c
> @@ -848,7 +848,8 @@ static Property sparc_cpu_properties[] = {
>                           qdev_prop_uint64, target_ulong),
>      DEFINE_PROP_UINT32("fpu-version", SPARCCPU, env.def.fpu_version, 0),
>      DEFINE_PROP_UINT32("mmu-version", SPARCCPU, env.def.mmu_version, 0),
> -    { .name  = "nwindows", .info  = &qdev_prop_nwindows },
> +    DEFINE_PROP("nwindows",     SPARCCPU, env.def.nwindows,
                               ^^^^
stray whitespace

> +                qdev_prop_nwindows, uint32_t),
>      DEFINE_PROP_END_OF_LIST()
>  };
>